cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] - master_buffer alloc only on pipelining set on

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sat, 21 Apr 2007 23:51:28 +0200 (CEST)

On Sat, 21 Apr 2007, Robert Iakobashvili wrote:

> Now, hopefully, the correct patch. Passes libcurl tests, pipelining tested
> against lighttpd server.
>
> Still, not sure, if mainstream neads it, but embedded people may like it.

I'm all for not using more memory than required.

But your patch fails test 530 for me:

test 530...[HTTP GET using pipelining]

** MEMORY FAILURE
Leak detected: memory still allocated: 49152 bytes
At 49834f4, there's 16384 bytes.
  allocated by url.c:2843
At 497ed2c, there's 16384 bytes.
  allocated by url.c:2843
At 497a564, there's 16384 bytes.
  allocated by url.c:2843

  - abort tests
Received on 2007-04-22