Re: Patch to add Amazon AWS authentication
Date: Mon, 23 Apr 2007 22:44:47 +0200 (CEST)
On Mon, 23 Apr 2007, Mark Atwood wrote:
>> 3 - Can you please provide at least some test cases as well that make sure
>> that the basic AWS functionality is there? I figure some of the existing
>> tests for other auth methods should work as good examples/input on how to
>> write them.
> I will do that. The tricky bit is that since AWS transfer is not free
> (20c/GiB), someone will need an AWS account to run the test.
I meant test cases for curl's own test suite!
>> 4 - I didn't see anything in the code that made sure that OpenSSL is
>> enabled, so I'm quite sure it'll fail if you build without it. Right?
> I think I check for OpenSSL in the configure.in, but I will review that
Oh, then maybe I just overlooked it. I'll try to review your patch properly
within a day or two and I might get back with some further questions then.
-- Commercial curl and libcurl Technical Support: http://haxx.se/curl.htmlReceived on 2007-04-23