Re: SFTP create missing directories patch
Date: Sat, 2 Jun 2007 23:12:52 +0200 (CEST)
On Fri, 1 Jun 2007, Tom Regner wrote:
> I just implemented that sftp will honour the CURLOPT_FTP_CREATE_MISSING_DIRS
> setting - a feature I need right now;
> I'm quite unsure if the way I implemented it will meet with approval on your
> part - I simply await your comments.
Thanks for your contribution! Here's my comments:
First, the code is > 80 columns wide and doesn't follow the curl code style in
regards to indenting etc.
But functionality wise, I'm a bit concerned that you take all
libssh2_sftp_open() failures as a signal to attempt the creation of missing
dirs. Wouldn't it make more sense to check for specific errors?
-- Commercial curl and libcurl Technical Support: http://haxx.se/curl.htmlReceived on 2007-06-02