cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Inconsistency with cookies initialization?

From: Shmulik Regev <shmulbox_at_gmail.com>
Date: Sun, 29 Jul 2007 16:32:08 +0300

> That sounds like a bug to me.
>
> The share should only be a container for data instead of in the easy
handle,
> so if no cookie stuff has been enabled for the handle that uses the share,
I
> don't think it should have the cookie pointer initialized...

I guess that the following trivial patch will do then.

Cheers,
Shmul

Index: C:/dev/repos/trunk/rapport/thirdparty/curl-7.16.4/lib/url.c
===================================================================
--- C:/dev/repos/trunk/rapport/thirdparty/curl-7.16.4/lib/url.c (revision
1956)
+++ C:/dev/repos/trunk/rapport/thirdparty/curl-7.16.4/lib/url.c (working
copy)
@@ -1618,11 +1618,6 @@
         Curl_share_unlock(data, CURL_LOCK_DATA_SHARE);

       }
-#if !defined(CURL_DISABLE_HTTP) && !defined(CURL_DISABLE_COOKIES)
- /* check cookie list is set */
- if(!data->cookies)
- data->cookies = Curl_cookie_init(data, NULL, NULL, TRUE );
-#endif /* CURL_DISABLE_HTTP */
       /* check for host cache not needed,
        * it will be done by curl_easy_perform */
     }
Received on 2007-07-29