cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Fwd: [PATCH] check ip callback

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 26 Sep 2007 11:12:52 +0200 (CEST)

On Fri, 21 Sep 2007, Daniel Stenberg wrote:

>> Second, it would be better to use sockaddr_storage unless we want to deal
>> with memory ownership.
>
> Speaking of that, in your version of this patch how are you dealing with
> sockaddr memory ownership? (and painfully enough the sockaddr_storage struct
> doesn't exist everywhere)

While this question reamains open, I'll add another one about this patch:

Can we really be sure adding arguments to a callback won't break the ABI for
existing applications? We can certainly be sure that we break the API and that
may in fact be annoying enough for application authors...

I thus propose that we do use a new option name for this extended callback,
and support the former one with the existing name but we document it as
deprecated and add it for removal on the next soname bump.

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2007-09-26