cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] socklen_t fix attempt

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 19 Dec 2007 23:44:33 +0100 (CET)

On Wed, 19 Dec 2007, Yang Tse wrote:

> Based on your patch here's another incomplete one which takes care of
> potential redefinition issues and that should be good if the configure
> script defines socklen_t or not.

I'm attaching my updated version which is basically your two files and my
added types.h.dist file, in one single patch. The .dist file is necesary since
it makes sure there's a types.h present in release archives.

In what ways is this still incomplete?

Is this method working fine if we try to install the headers when we build
outside the source dir on a *nix box? I guess I need to check it out...

> Should we go this route ?

Do we have any other reasonable approach to select from? To me this seems like
a doable way at least.

> A patch and a file since it seems that today I'm unable to properly diff it.

Just for the future:

You can't "cvs diff" it unless it is first "cvs add"ed, and then you need to
'cvs diff -N' to get it in the diff.

Optionally, you can append "custom" diffs to the main diff with just "diff -uN
/dev/null newfile.c >> patchfile"

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html

Received on 2007-12-19