cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] SOCKS4a support

From: Cory Nelson <phrosty_at_gmail.com>
Date: Thu, 3 Jan 2008 01:17:35 -0800

On Jan 2, 2008 1:42 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Jan 2, 2008 9:34 PM, Richard Atterer <richard_at_2008.atterer.net> wrote:
>
> > Yes - SOCKS 4a and DNS over SOCKS 5 have much the same functionality.
> > Separate support for 4a might still be useful if the remote server only
> > supports one of the two versions...
>
> I agree with that and I just committed your patch (with my added docs
> and some minor comments).
>
> It made me think about the socks5-dns-resolve approach. Would it make
> sense to call that SOCKS5A just to be consistent? I mean instead of
> having that separate setopt option?
>

SOCKS4a is a commonly used name. SOCKS5a is not - best not to add any
confusion.

Furthermore, a lot of people (me included) are under the impression
that the default for 4a and 5 is to do DNS through the proxy, so any
documentation should be very clear about any flags you need to use to
get expected functionality.

-- 
Cory Nelson
Received on 2008-01-04