cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: Bug 2351645

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 8 Dec 2008 22:53:16 +0100 (CET)

On Thu, 4 Dec 2008, Igor Novoseltsev wrote:

> The point is that we remove handle that is NOT in the head of the line! This
> was exact the problem, if you remember. The handle that is not in the head
> was not removed, causing crash later, when the handle is accessed during
> manipulations on the list.
>
> We should not touch the XXXchannel_inuse at all, since we remove the handle
> that is not in the head and the other handle that is in the head probably
> deals uses the channel. If you agree with this we have to remove the newly
> added function Curl_getoff_all_pipelines :(

Or what about making Curl_getoff_all_pipelines() deal with the situation
properly and only set *_inuse to FALSE if the handle actually was head - and
thus work for either situation? See the attachment to this mail for my
suggested fix. (diff against current CVS HEAD)

Do you think this works?

-- 
  / daniel.haxx.se

Received on 2008-12-08