Re: sukender: curl/include/curl curl.h,1.380,1.381
Date: Thu, 09 Apr 2009 12:01:47 +0200
> Daniel Stenberg wrote:
>> On Thu, 9 Apr 2009, Yang Tse wrote:
>>> Could this
>>> change be rolled back now that I've made test #558 and #559 being
>>> also skipped when testing a Win32 libcurl DLL?
>> It should be reverted. It is substandard.
>> We ONLY add dependencies on custom variables if they are properly
>> prefixed and this USES_DIRECT_CURL_UTILITIES one isn't.
>> Not to mention that there's no comment or other explanation for the
>> define which should be a requirement as well.
> Alright, sorry for the inconvinience. Hopefully this is a very short
> commit. About the comment: I was a bit in a hurry, sorry again.
> So, how could we do to avoid the linking problem on tests/server targets
As explained before, my knowledge of libcurl is (very) limited, as well as my time for it. So if you got an idea to fix the problem, I'll take it.
Or maybe renaming the definition and adding comments would be enough? If so, please tell me a suitable name. Is "CURL_INCLUDES_LIBCURL_SOURCES" a good name? About the comments I suggest:
* Define this in tests projects that include libcurl
* sources without linking to the library, in order to avoid
* linkage inconsistencies.
-- Sukender PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/Received on 2009-04-09