cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: sukender: curl/tests/libtest CMakeLists.txt,NONE,1.1

From: Sukender <suky0001_at_free.fr>
Date: Sat, 11 Apr 2009 05:34:13 +0200

Piotr Dobrogost wrote:
> Sukender
>
> In the root CMakeLists.txt there is this code
>
> IF(WIN32)
> SET(CURL_LDAP_HYBRID OFF)
> OPTION(CURL_LDAP_WIN "Use W$ LDAP implementation" ON)
> MARK_AS_ADVANCED(CURL_LDAP_WIN)
> ELSE()
> OPTION(CURL_LDAP_HYBRID "W$ LDAP with non-W$ compiler" OFF)
> MARK_AS_ADVANCED(CURL_LDAP_HYBRID)
> SET(CURL_LDAP_WIN OFF)
> ENDIF()
>
>
> I think that for consistency that should be rather
>
> IF(WIN32)
> OPTION(CURL_LDAP_WIN "Use W$ LDAP implementation" ON)
> MARK_AS_ADVANCED(CURL_LDAP_WIN)
> SET(CURL_LDAP_HYBRID OFF)
> ELSE()
> OPTION(CURL_LDAP_HYBRID "W$ LDAP with non-W$ compiler" OFF)
> MARK_AS_ADVANCED(CURL_LDAP_HYBRID)
> SET(CURL_LDAP_WIN OFF)
> ENDIF()
>
>
> Sorry for this nitpicking but that's my way of thinking. I'm trying to
> point out everything that seems to be not right no matter how important
> it is. :)

Hi Piotr,

Well, *THAT'S* nitpicking! ;p But yes, I agree. Please proceed.
Nice to see your interest in the scripts.

-- 
Sukender
PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/
Received on 2009-04-11