cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH] get rid off misleading timeout in libcurl-NSS

From: Daniel Stenberg <>
Date: Wed, 14 Oct 2009 05:33:20 +0200 (CEST)

On Thu, 8 Oct 2009, Kamil Dudka wrote:

> here is a proposed patch for lib/nss.c fixing the above mentioned timeout
> issues. Now it computes the connection timeout properly. Then it set the SSL
> socket to non-blocking mode. And finally it drops all the untested code
> computing timeouts during a transfer.
> Anybody feels like doing a review? Thanks in advance!

I'm not a NSS wizard and I only read the patch (without testing anything), but
based on this and the previous thread about this subject, it certainly looks
more correct than we previously used.

Ideally, we should make the SSL handshake get done entirely non-blocking one
day and then we can get rid of the remaining timeout-awareness from that file.

List admin:
Received on 2009-10-14