cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] get rid off misleading timeout in libcurl-NSS

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Wed, 14 Oct 2009 18:04:58 +0200

On Wed October 14 2009 08:10:37 Kamil Dudka wrote:
> On Wednesday 14 of October 2009 05:33:20 Daniel Stenberg wrote:
> > I'm not a NSS wizard and I only read the patch (without testing
> > anything), but based on this and the previous thread about this subject,
> > it certainly looks more correct than we previously used.
> >
> > Ideally, we should make the SSL handshake get done entirely non-blocking
> > one day and then we can get rid of the remaining timeout-awareness from
> > that file.
>
> Thanks for review! I'll apply the patch right after the 7.19.7 release if
> there are no objections untill then.

FYI I've just built it for rawhide Fedora to reveal possible downsides
of that patch:

http://koji.fedoraproject.org/koji/buildinfo?buildID=136624

Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2009-10-14