cURL / Mailing Lists / curl-library / Single Mail


Re: Patch to add support for ENG certificate type

From: Camille Moncelier <>
Date: Fri, 16 Oct 2009 06:57:49 +0000

> From: Daniel Stenberg <>
> To: libcurl development <>
> Date: Thu, 15 Oct 2009 23:41:05 +0200 (CEST)
> Subject: Re: Patch to add support for ENG certificate type
> On Thu, 15 Oct 2009, Camille Moncelier wrote:
>> This patch adds support for the file type SSL_FILETYPE_ENGINE for the client certificate.
> Thanks for your efforts to helping out and improving libcurl!
Thanks for your reply.

> So what's the word about the "XXXX still needs some work" ?
To be honest it's just the result of a copy/paste from some code below.
(SSL_FILETYPE_ENGINE for privatekey)

> And it does use // comments which we don't like here.
I changed the comment style.

> And commenting out code is not nice, we either leave it,
> we make it conditional on some preprocessor magic or we remove it.
I commented the code to explain why I removed it, I deleted theses
lines in the new patch.
(or do you prefer a "#if 0" "#endif" ?)

Camille Moncelier

List admin:

Received on 2009-10-16