cURL / Mailing Lists / curl-library / Single Mail


Re: [Patch] Fix duplicated code in http.c

From: Julien Chaffraix <>
Date: Tue, 2 Feb 2010 11:17:26 -0800

On Tue, Feb 2, 2010 at 12:47 AM, Daniel Stenberg <> wrote:
> On Tue, 2 Feb 2010, Julien Chaffraix wrote:
>> the attached patch removes a copy and paste issue in http.c.
> I think you were a bit too quick there. authhost and authproxy may look
> almost the same, but they are not and I think that function needs to deal
> with both properly!

Right! The 2 'if's that are nearly the same and the comment just has
one word that changes which confused me. I don't see how it can be
made less confusing though so just discard this rant.

>> As a bonus, there is a trivial comment fix for ftp.c.
> Thanks, I'll apply!


List admin:
Received on 2010-02-02