cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: PATCH: Allow user:password to be passed in SMTP urls.

From: Ben Greear <greearb_at_candelatech.com>
Date: Fri, 26 Mar 2010 09:42:43 -0700

On 03/26/2010 08:30 AM, Daniel Stenberg wrote:
> On Fri, 26 Mar 2010, Ben Greear wrote:
>
>> Could we just change the code to parse user:passwd for ALL protocols
>> and let protocols ignore the user:passwd as needed?
>
> Yeah, I think so. As long as the parsing doesn't break legitimately
> formatted URLs, but I don't know of any such cases where that would happen.
>
> But do note that this is a libcurl extension. These protocols aren't
> specified to support name and password within the URLs.
>

Updated patch is attached.

I also noticed that a previous patch for telnet introduced a compile warning.
I'm going to figure out how to enable -Werr and then fix all warnings for
64-bit and just enable -Werr in my testing so that this quits happening.

Thanks,
Ben

-- 
Ben Greear <greearb_at_candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2010-03-26