On Monday 26 of April 2010 13:03:19 Daniel Stenberg wrote:
> > POSIX fnmatch(3) vs. Curl_fnmatch()
>
> So they are otherwise 100% expression compatible?

As for the test-cases, I am observing some minor diferences on my box, mostly
in handling of some corner cases:

+fnmatch("[", "[") should return 2 (returns 1)
+fnmatch("[]", "[]") should return 2 (returns 1)
+fnmatch("[a-z]", "A") should return 1 (returns 0)
+fnmatch("[A-Z]", "c") should return 1 (returns 0)
+fnmatch("*.txt", ".txt") should return 0 (returns 1)
+fnmatch("****.txt", ".txt") should return 0 (returns 1)
+fnmatch("\", "\") should return 2 (returns 1)
+fnmatch("\"\$\&\'\(\)", ""$&'()") should return 0 (returns 1)

We can tweak it to match with the other implementation.

I also suggest to enable valgrind as it reports no error anyway!

--- a/tests/data/test573
+++ b/tests/data/test573
@@ -29,8 +29,5 @@ nothing
 ===========================
 ===========================
 </stdout>
-<valgrind>
-disable
-</valgrind>
 </verify>
 </testcase>

Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-04-26