cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] RTMP: added swf verification options

From: Howard Chu <hyc_at_highlandsun.com>
Date: Fri, 23 Jul 2010 19:59:54 -0700

Przemyslaw Iskra wrote:
> On Fri, Jul 23, 2010 at 05:48:37PM -0700, Howard Chu wrote:
>> Przemyslaw Iskra wrote:
>>> On Fri, Jul 23, 2010 at 04:49:06PM -0700, Howard Chu wrote:
>>>> This patch is a bad idea. You should simply use the URL options.
>>>> Accessing fields inside the RTMP structure will make this code
>>>> version-dependent and cause incompatibilities when librtmp is updated.
>>>
>>> Do you mean I should use the overcomplicated RTMP_SetupStream()
>>> function ?
>>
>> No. All the functionality you need are already in the existing libcurl code.
>> No other librtmp APIs are needed. RTMP_SetupStream() is deprecated and will be
>> removed.
>>
>>> It is the only way I see to pass those values to librtmp without
>>> touching the struct.
>>
>> Then you haven't read the manpage.
>>
>> http://rtmpdump.mplayerhq.hu/librtmp.3.html
>
> Understood.
>
> "swfVfy=1" is the common way to do it.
>
> However, I still cannot see any way to pass swfHash and swfSize
> directly.
>
> I don't like it downloading any file "behind my back".
> Moreover:
> - it isn't compatible with curl multi (locks whole session while
> downloading the file)
> - that HTTP_get() function is far from perfect
> - this approach won't allow me to lie about swf hash or size
> - there was something else I cannot think of right now

If you need to lie about such things, then just create the appropriate entry
in the .swfinfo file.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-07-24