cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Watcom makefiles

From: Guenter <lists_at_gknw.net>
Date: Wed, 28 Jul 2010 06:08:54 +0200

Am 28.07.2010 05:49, schrieb Guenter:
> One think I have not yet looked at closer is the output of 'curl -V'
> which looks a bit strange:
> curl 7.21.0 (i386-pc-win32) libcurl/7.21.0
>
>
> Protocols: dict file ftp http imap ldap pop3 rtsp smtp telnet tftp
> Features: AsynchDNS IPv6 Largefile SPNEGO
>
> well, probably not clearly visible in here in mail what I mean, but I
> describe: 2 empty lines between curl version and Protocols, and no
> linebreak for Features.
seems to me that puts() from Watcom is somehow broken with both OW 1.8
and 1.9; I patched src/main.c to use printf() and this makes the version
output apear as usual:

--- src/main.c.orig Tue Jun 01 17:55:26 2010
+++ src/main.c Wed Jul 28 06:03:14 2010
@@ -3059,7 +3059,7 @@
          for (proto=curlinfo->protocols; *proto; ++proto) {
            printf("%s ", *proto);
          }
- puts(""); /* newline */
+ printf("\n"); /* newline */
        }
        if(curlinfo->features) {
          unsigned int i;
@@ -3088,7 +3088,7 @@
            if(curlinfo->features & feats[i].bitmask)
              printf("%s ", feats[i].name);
          }
- puts(""); /* newline */
+ printf("\n"); /* newline */
        }
      }
      return PARAM_HELP_REQUESTED;

does anything speak against changing this in our code?

Gün.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-07-28