cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] NTLM & Astaro & bug 75

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 20 Apr 2011 20:09:17 +0200 (CEST)

On Wed, 20 Apr 2011, David Woodhouse wrote:

>> +{
>> + size_t i;
>> + for(i=0; i<length; i++) {
>> + dest[2*i] = (unsigned char)src[i];
>> + dest[2*i+1] = '\0';
>> + }
>
> That only works for ASCII input.

Right, it's limited but a small step forwards from what we have now.

> Don't we already have working charset conversion routines available, to
> convert to UCS-2 (or is it UTF-16)?

No, not in all builds at least. We normally have nothing (else) that needs to
convert between charsets.

> And shouldn't we set NTLMFLAG_NEGOTIATE_UNICODE in our initial Type 1
> message now that we support it?

I'm not completely sure, and I don't have any live NTLM servers and proxies to
test new variations against, so I prefer to move gently and conservatively.

Of course, I'll welcome if someone else does the job!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-04-20