cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Use Correct A/W function for Win32 calls

From: Vincent Torri <vincent.torri_at_gmail.com>
Date: Tue, 17 May 2011 07:48:47 +0200

On Tue, May 17, 2011 at 7:34 AM, Jon Griffiths <jon_p_griffiths_at_yahoo.com>wrote:

> I only subscribed yesterday, so I didn't see it.
>
> IIRC, LoadLibraryA/W are defined by macros, so #defining it to LoadLibrary
> above
> the call when not defined should take care of Win CE. Perhaps you could
> resubmit
> your patch with that change?
>
>
do not do that. Don't mess the LoadLibrary definition. the choice of having
the A or W function is done with the UNICODE macro. If you really want to
choose one or the other function do something like that

#ifdef UNICODE
LoadLibraryW(***)
#else
LoadLibraryA(***)
#endif

But it should be useless. I have written some equivalent functions of dlopen
dlclose, etc... for Windows XP and CE without doing what i wrote above.

Vincent Torri

>
> J
>
>
> ----- Original Message ----
> From: "girish_at_shankar-software.org" <girish_at_shankar-software.org>
> To: Jon Griffiths <jon_p_griffiths_at_yahoo.com>; libcurl development
> <curl-library_at_cool.haxx.se>
> Sent: Tuesday, May 17, 2011 15:46:16
> Subject: Re: [PATCH] Use Correct A/W function for Win32 calls
>
> > Hi,
> >
> > Many thanks for your work on cURL. Attached patch changes a couple of
> win32
> > calls to use the correct A/W version,
> >
> > allowing my work build system to build with UNICODE defined. There may
> well be
> > other calls in tree that could be changed, but this works for me (TM).
> >
> > Cheers
> > Jon
>
> How the deuce is this different from the patch I submitted a few days ago
> with
> subject [Patch] Windows fixes?
>
> That patch was shot down because LoadLibraryA is not available on Windows
> CE.
>
> -------------------------------------------------------------------
> List admin: http://cool.haxx.se/list/listinfo/curl-library
> Etiquette: http://curl.haxx.se/mail/etiquette.html
>

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-05-17