cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Added AUTH NTLM for SMTP

From: Dan Fandrich <dan_at_coneharvesters.com>
Date: Mon, 8 Aug 2011 12:27:28 -0700

On Mon, Aug 08, 2011 at 08:07:12PM +0100, Steve Holme wrote:
> From an outsider's perspective, this seems quite long winded, is it always
> like this? The reason I ask is, I've got some more features I would like to
> add to the SMTP module as well as some fixes for bugs that I have noticed.

It's very useful if problems are discovered in the future, as 'git bisect'
can narrow the problem more precisely. It's also easier to review the code,
since changes that are peripheral to the main NTLM changes don't get in the
way as those more complex changes are reviewed. While doing it this way can
be very useful and therefore encouraged since it's usually not too onerous
(and 'git add -i' usually makes it pretty easy), it's negotiable if the
submitter can claim undue hardship :-)

>>> Dan
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-08-08