cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Added AUTH NTLM for SMTP

From: Yang Tse <yangsita_at_gmail.com>
Date: Wed, 10 Aug 2011 22:11:36 +0200

Hi there,

> As such, can you discard my last patch with the curl_ntlm move in? I will
> patch this up after this patch is pushed ;-)

Relative to that one... It would be nice to keep the handling of out
of memory condition when calling Curl_base64_* in the same function
where Curl_base64_* is called. Probably it would be better if
Curl_ntlm_create_type1_message() and Curl_ntlm_create_type3_message()
did not call Curl_base64_encode(). There's no problem with
Curl_ntlm_decode_type2_message() given that it handles OOM condition
of Curl_base64_decode().

-- 
-=[Yang]=-
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-08-10