cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] Curl_gethostname() may or may not return the hostname as a FQDN

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Sun, 18 Sep 2011 14:34:52 +0100

Hi all,

> Thank you for the extra info chaps... I will start hacking the manual
> in Textpad and see how I get on ;-)

I've had an interesting couple of hours writing content for the man pages
and as such have attached the appropriate patch :)

This patch includes:

* Information about the format of the URL.
* Talks about the various parts of the URL from Schema (Protocol), through
host, port to path.
* Gives protocol specific information about path for HTTP, FTP and SMTP.
* Includes appropriate examples, some of which you will recognise from the
main curl man page.

Note: It still includes a paragraph about the "fragment part" which I
understand was prior to v7.20. I'm not sure what this is related to as I've
not been involved with libcurl that long so I have left it there (although
corrected a spelling mistake).

> > I pushed your patch just now btw!
>
> Fantastic. However, I performed a GIT pull this morning and
> unfortunately I can only see updates from Yang and Guenter.

The update seems to have come through now - Cheers Daniel.

I want to provide a follow up patch that will:

* Move HOSTNAME_MAX into Curl_gethostname.h as there are definitions for
this in Curl_gethostname.c and Curl_ntlm_msg.c
* Modify smtp.c to use HOSTNAME_MAX rather than hardcoding it to 1024 (which
happens to be the same length as HOSTNAME_MAX)
* Tidy up Curl_ntlm_msg.c to remove the post Curl_gethostname() code that
strips of the domain as this is no longer required
 
Does anyone object to this / is anyone working on these at the moment?

Cheers

Steve

Received on 2011-09-18