cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] refactoring select.c phase 1

From: Amr Shahin <amrnablus_at_gmail.com>
Date: Mon, 26 Sep 2011 01:59:03 +0300

On Mon, Sep 26, 2011 at 1:44 AM, Daniel Stenberg <daniel_at_haxx.se> wrote:

> On Mon, 26 Sep 2011, Amr Shahin wrote:
>
> ok so i'm done with the patch, but i need to make sure i didn't break
>> anything, is there a certain test that would give me this certainty or do i
>> need to be creative?
>>
>
> Good question. I don't think we have any particular dedicated tests for the
> select functions, but if you can run through all the existing test cases
> fine with your change applied I would say it is a pretty good sign... =)
>
>
> --
>
> / daniel.haxx.se
> ------------------------------**------------------------------**-------
> List admin: http://cool.haxx.se/list/**listinfo/curl-library<http://cool.haxx.se/list/listinfo/curl-library>
> Etiquette: http://curl.haxx.se/mail/**etiquette.html<http://curl.haxx.se/mail/etiquette.html>
>

Cool, by the way. In what cases does HAVE_POLL_FINE *not* get defined (i
know it is on my fedora), i think it would be wise to run the test with both
cases.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-09-26