cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] Added support for NTLM authentication to SMTP

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sat, 15 Oct 2011 22:53:27 +0200 (CEST)

On Mon, 3 Oct 2011, Steve Holme wrote:

> Ah - I went beyond 78 characters on a couple of lines.
>
> Although it's not my usual code style, I do try and make sure that I don't
> go beyond the boundary (even correcting mistakes that others have made
> before me), but I obviously missed these... so cheers for catching them ;-)

Most of them are caught automatically when I build so it's very easy to catch
them... and I also have scripts for my editor that can search for and correct
most of them automatically.

> You also mentioned the other day about writing test harnesses for the smtp
> changes I introduced last week... What would you say is the best place to
> start, and sorry for the obvious question, do the tests run under Windows?

I'm sorry but the tests don't run (very well) on native Windows. I believe
they might run fairly good with cygwin.

The first three steps for diving into writing SMTP tests could be:

  1 - read tests/README (not yet available as a separate web page)
  2 - check out existing SMTP tests in tests/data/test*
  3 - read http://curl.haxx.se/dev/runtests.html

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-10-15