cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: query part for non-HTTP(S) URLs

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 24 Nov 2011 23:37:05 +0100 (CET)

On Thu, 24 Nov 2011, Jonas Schnelli wrote:

Thanks, your patch has been committed and pushed! Nice work.

> What about?
> * _PROXY

> (like IMAP_proxy, IMAPS_proxy, POP3_proxy, etc.)? I do not have any idea how
> the proxys are internally handled.

Only the protocols[] array in lib/url.c is getting searched when libcurl
parses the URL as passed in with CURLOPT_URL. The other protocol structs are
used to allow internals to dynamicaly change how to treat the protocols, but
they will then just continue using the data from the URL that was already
parsed.

> Here is the patch for changing curl to act like described in the table
> above. So curl would than be more URI/RFC conform.

Thanks! For even more points next time: make a "real" commit in your end (with
a full and proper commit message) and use 'git format-patch' to get it to send
us. It smoothes the path even more for us who receive/push patches.

> Tests run fine with the patch.

Yeps, they do for me too!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-11-24