cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] add support for pkg-config detection of libidn

From: Mark Brand <mabrand_at_mabrand.nl>
Date: Tue, 29 Nov 2011 15:11:23 +0100

Daniel Stenberg wrote:
> On Tue, 29 Nov 2011, Mark Brand wrote:
>
>> Searching CURL_CHECK_PKGCONFIG in configure.ac turns up several
>> places where pkg-config is used These probably model the pattern you
>> would like to see used, but I would like to ask for confirmation of
>> this. It's rather verbose, especially compared to PKG_CHECK_MODULES
>> and there is a lot of repeated logic. I would almost suggest
>> implementing something like PKG_CHECK_MODULES to tidy this up, but
>> then it already exists! In the real world the best option might be
>> just to repeat the logic again for libidn. What is your view?
>
> Basically, we avoid depending on pkg-config's m4 macros by doing our
> own - we've already seen how PKG_CHECK_MODULES isn't working on a
> range of build machines.
>
> So instead of adding another buildconf requirement, we provide the
> logic ourselves.
>
> I think we can simplify our configure script a lot by writing up our
> own PKG_CHECK_MODULES version and use that consistently through-out.
> Currently we call CURL_CHECK_PKGCONFIG first and then a series of
> pkg-config invokes for lots of dependencies...
>

I would like to hear comments on the possibility of distributing pkg.m4
with curl. I'm no autotools or m4 expert, but it seems like a
possibility to consider. There are version checks in there that I hope
allow for graceful failure when a suitable pkg-config is not available.
All in the name of not reinventing the wheel..

Mark

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-11-29