cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] add support for pkg-config detection of libidn (Daniel)?

From: Guenter <lists_at_gknw.net>
Date: Wed, 30 Nov 2011 18:41:42 +0100

Am 29.11.2011 23:27, schrieb Guenter:
> Marc,
> Am 29.11.2011 23:09, schrieb Mark Brand:
>>
>>> 1st of all thanks for your further work on it.
>>> I though believe that adding pkg.m4 to curl is not an option due to
>>> the GPL license it falls under - AFAICT that is not what we want to
>>> have in our sources.
>> But the header of pkg.m4 reads:
>>
>> # As a special exception to the GNU General Public License, if you
>> # distribute this file as part of a program that contains a
>> # configuration script generated by Autoconf, you may include it under
>> # the same distribution terms that you use for the rest of that program.
>>
>> Are there more reasons that the project does not want to include m4
>> files? My understanding is that this is exactly the use case for
>> including another project's m4 files.
> I think this paragraph covers my concerns.
>
>>> Also Yang has now coded a workaround, and already commited (and I
>>> believe that his approach works - as usual); so lets see what next
>>> autobuilds now show:
>>> http://curl.haxx.se/dev/builds.html
>>> and I assume that most likely the issue is already solved with
>>> Yang'spatch ...
>>
>> Yes, that's true. But it still might be a good idea to consider whether
>> it makes sense for curl to continue to develop and maintain its own
>> pkg-config detection code in configure.ac now that there is a standard
>> ready-made solution.. Daniel indicated earlier in this thread that he
>> was even sympathetic to the idea of reimplementing PKG_CHECK_MODULES,
>> but there don't seem to be any obstacles now to just using the real one.
>>
>> That's just my 2 cents of course. Are there compelling counterarguments
>> that I'm overlooking?
> that's then Daniel's decision, and I've no strong opinion on this;
> also I agree that our configure.ac would probably look more readable if
> we would have the pkg-config checks as macro, sub function, whatever ...
> though I'd suggest that you wait for Daniel's and others comments before
> you start to code more on this, and get finally frustrated if your work
> doesnt make it into sources ...
Daniel, any thoughts about this? I sounds to me that Mark wants to / is
willing to contribute further and rewrite the configure.ac checks ...

Gün.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-11-30