cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Using fopensocket instead of direct socket call

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sat, 3 Dec 2011 21:08:38 +0100 (CET)

On Fri, 2 Dec 2011, Gokhan Sengun wrote:

> in function ftp_state_use_port(), direct call to socket() is used. However
> upon closing the socket fclosesocket function is used. It looks to me (if
> not missing something), it should check whether fopensocket is set and call
> this function if happens to be so.

This this clearly looks like a bug. We should write up a test case to track
this!

> I would appreciate if somebody having git environment could verify and push
> this.

You don't need git to fix this, you can just get the source, fix the code,
make a diff and send the patch here...

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-12-03