cURL / Mailing Lists / curl-library / Single Mail

curl-library

PATCH: Establishing data connections in FTP has been made non-blocking for multi interface

From: Gokhan Sengun <gokhansengun_at_gmail.com>
Date: Sun, 18 Dec 2011 23:56:40 +0200

Hi there,

I have implemented required functionality to make "Establishing data
connections in FTP non-blocking for multi interface".

Here are a few remarks:

1- Two new error codes are introduced.

CURLE_FTP_ACCEPT_FAILED to be set whenever ACCEPTing fails because of FTP
server connected.
CURLE_FTP_ACCEPT_TIMEOUT to be set whenever ACCEPTing timeouts.

Neither of these errors are considered fatal and control connection remains
OK because it could just be a firewall blocking server to connect to the
client.

2- Two new parameters introduced.

CURLOPT_ACCEPTTIMEOUT
CURLOPT_ACCEPTTIMEOUT_MS

These define the maximum amount of time FTP client is going to wait server
to connect. If one of these parameters is set, it will be used otherwise
default accept timeout (DEFAULT_ACCEPT_TIMEOUT - 1 minute) will be used to
detect the timeout.

I ran the tests and all looked OK except the one complaining about
difference in symbols and headers.

Please do not hesitate to change the code to better suit rest of the
library.

Thanks.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2011-12-18