cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: PATCH: Establishing data connections in FTP has been made non-blocking for multi interface

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 20 Dec 2011 23:32:52 +0100 (CET)

On Wed, 21 Dec 2011, Gokhan Sengun wrote:

> In function Curl_socket_check with commit
> 5527417afae062d7a2b12ee80730a0ab22b86eab, you seem to leave "pfd" array's
> size as 2 but it could potentially be 3 (readfd0 + readfd1 + writefd) and
> may lead stack corruption when for some condition all three are to be
> watched. Currently it is no problem since at most two sockets are being
> polled.

Oh, I clearly messed up. I'll make sure to do that fix as well, thanks for
your keen eyes!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-12-20