cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] pop3.c: Fixed drop of final CRLF in EOB checking

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Mon, 20 Feb 2012 23:07:24 +0000

Hiya,

> > The logs confused me to begin with as I was expecting to see "0d 0a"
> > between each line rather than just 0a. Is that by design / a flaw of
> > the test scripts when running under linux or is it intentional?
>
> No, it is actually just how the test data is written. The test file is
using
> unix newlines and there are no additional [CR]s added so they are just
[LF].

Fair enough... I thought that would be the case but I just wanted to check.

> Yes, and that's the problem here I think. The test/ftpserver.pl is what
> sends the response to the POP3 RETR command (see the RETR_pop3
> function) and it sends everything within the <data> and then a trailing
> "\r\n.\r\n" sequence.
>
> If I understand you correctly, that terminating string should only be
> ".\r\n". Right?

Pretty much yep. You would need to convert that last LF in the test script
to be a CRLF so that the data matches, or convert all newlines in the script
to be CRLF, alternatively have RETR_pop3 convert single LF's to CRLF
combinations ;-)

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2012-02-21