Marc Hoersken <info_at_marc-hoersken.de> wrote:

> And here is a little follow up patch for aesthetic purposes. Could
> optionally be squashed into the previous one.
> 0002-curl_schannel.c-Synchronize-assignment-order-with-pa.patch

> Just for aesthetic purposes the assignment order should be
> synchronized with the parameter order.
> [...]
> --- a/lib/curl_schannel.c
> +++ b/lib/curl_schannel.c
> @@ -92,9 +92,9 @@ static CURLcode verify_certificate(struct connectdata *conn, int sockindex);
> static void InitSecBuffer(SecBuffer *buffer, unsigned long BufType,
> void *BufDataPtr, unsigned long BufByteSize)
> {
> - buffer->cbBuffer = BufByteSize;
> buffer->BufferType = BufType;
> buffer->pvBuffer = BufDataPtr;
> + buffer->cbBuffer = BufByteSize;
> }

I'm not going to merge this one. Nowhere in "cURL Coding Standards"
says that assignment order of struct members should follow parameter
order. Additionally, existing assignment order already has some logic
it follows struct member declaration order.

Thanks,

-- 
-=[Yang]=-
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html