cURL / Mailing Lists / curl-library / Single Mail


Re: patch - select.c / Curl_socket_check() interrupted

From: Daniel Stenberg <>
Date: Tue, 7 Aug 2012 23:29:44 +0200 (CEST)

On Tue, 10 Jul 2012, Maxime Larocque wrote:

> The following patch corrects the problem (for curl 7.26 release, but look
> the same as 7.25):

Thanks a lot for the patch and your work on this, I finally got around to
merge and push it!

> - Curl_pp_multi_statemach(), in pingpong.c which returns
> CURLE_OUT_OF_MEMORY. Curl_socket_check() should not fail anyways, and I'm
> not sure which code should be returned...

As 0 from Curl_socket_check() implies a timeout, isn't
CURLE_OPERATION_TIMEDOUT the logical return code then?

> - the ! HAVE_POLL_FINE case in Curl_socket_check(); it uses select() but
> seems to have the same trouble at select.c:309

Yes. I'll add the same fix there right now.

List admin:
Received on 2012-08-07