cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: The #include in if2ip.c is made unconditionally which is bad and needs to be fixed

From: Frank Chang <frank_chang91_at_hotmail.com>
Date: Sat, 15 Dec 2012 14:49:33 -0500

>Thanks but you forgot the -u switch to diff so the patch is using an inferior
>format!
 
I tried diff -ru on HPUXB11.11 and i got an command line error message from HPUX11.11 OS
so I was forced to use diff -u.
 
>Also, one use (in file.c) was "ifndef" instead of ifdef, for a _second_
>include of the same header in the same C file. Why would anyone like that?
>Please fix.
 
Yes, you are correct

>The #include in if2ip.c is made unconditionally which is bad and needs to be
>corrected as well.

This was intentional since when we put the conditional define before #include if2ip.c we obtained a
whole bunch of compiler errors. Perhaps, your colleague Yang Tse and your self might look at
#include "setup.h" generated by the libcurl-7.28.1 current ./configure script. Thank you for all
of your help and please let me know how I can be of help thsi weekend to the libcurl project.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2012-12-15