cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] fix for Windows/MSVC build

From: Sergei Nikulov <sergey.nikulov_at_gmail.com>
Date: Wed, 12 Jun 2013 12:43:37 +0400

2013/6/12 Daniel Stenberg <daniel_at_haxx.se>

> On Wed, 12 Jun 2013, Sergei Nikulov wrote:
>
> I've found that tests on github master broken for MSVC.
>> This is old issue with gettimeofday which should be replaced with
>> tutil_tvnow() from test_utils.
>>
>
> Pull request on github also submitted https://github.com/bagder/**
>> curl/pull/70 <https://github.com/bagder/curl/pull/70>
>>
>
> Thanks. I'm curious about the "fixed MS VC10 build" commit though. You
> don't provide any commit message and the change isn't self-explanatory...
> Why is it needed?
>
>
Sorry, my bad :)
It is same issue as described here https://github.com/bagder/curl/pull/49

Without this fix I got error on linking stage

[322/602] Linking C executable tests\libtest\..\lib1900.exe
lib1900.c.obj : error LNK2019: unresolved external symbol gettimeofday
referenced in function test
tests\libtest\..\lib1900.exe : fatal error LNK1120: 1 unresolved externals
LINK Pass 1 failed. with 2

> --
>
> / daniel.haxx.se
> ------------------------------**------------------------------**-------
> List admin: http://cool.haxx.se/list/**listinfo/curl-library<http://cool.haxx.se/list/listinfo/curl-library>
> Etiquette: http://curl.haxx.se/mail/**etiquette.html<http://curl.haxx.se/mail/etiquette.html>
>

-- 
Best Regards,
Sergei Nikulov

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-06-12