cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: curl_multi_wait revent for extra_fd not set

From: Evgeny Turnaev <turnaev.e_at_gmail.com>
Date: Thu, 18 Jul 2013 17:33:27 +0400

2013/7/18 Dave Reisner <d_at_falconindy.com>:
> On Thu, Jul 18, 2013 at 04:43:23PM +0400, Evgeny Turnaev wrote:
>> 2013/7/18 Daniel Stenberg <daniel_at_haxx.se>:
>> > On Wed, 17 Jul 2013, Evgeny Turnaev wrote:
>> >
>> >> Diff in attach.
>> >
>> >
>> > Thanks, I edited it very slightly and pushed!
>>
>> Uhh. Sorry. I didnt tested it with real curl requests until now.
>> There is major flaw in patch.
>> Fix in attachment.
>> Sorry.
>>
>
> This seems like it's still wrong. You're clobbering the value of 'i',
> which might be used to store the return from Curl_poll, and possibly
> assigned to *ret. You need a separate variable to iterate through
> extra_fds.revents[].

You are right Dave.
Another fix in attachment.

>
>
>> >
>> > --
>> >
>> > / daniel.haxx.se
>> >
>> > -------------------------------------------------------------------
>> > List admin: http://cool.haxx.se/list/listinfo/curl-library
>> > Etiquette: http://curl.haxx.se/mail/etiquette.html
>
>
>> -------------------------------------------------------------------
>> List admin: http://cool.haxx.se/list/listinfo/curl-library
>> Etiquette: http://curl.haxx.se/mail/etiquette.html
>
> -------------------------------------------------------------------
> List admin: http://cool.haxx.se/list/listinfo/curl-library
> Etiquette: http://curl.haxx.se/mail/etiquette.html

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2013-07-18