cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH 0/6] Re: Bug: libcurl truncates passwords longer than 255

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Mon, 19 Aug 2013 14:57:01 +0100

Hi guys,

On Mon, 19 Aug 2013, Steve Holme wrote:

> > This way we don't have to try and compare emails with code and don't
> > have to try and save emails as .patch files where we can get the
> > line endings wrong or even incorrect line wrappings - From my own
> > perspective I can then use the built in review features of
> > TortoiseGIT's ;-)

I'm not sure if my client got things wrong (Outlook) or my provider
(Hotmail) or whether the code in patch 3 was formatted incorrectly - hence
my suggestion but perhaps you can help me out...

The section where user, passwd and options is allocated had the following
problems towards the end of the patch:

"options =" ended up on the same line as the "passwd = malloc(...)" with the
malloc on the next line
The test for the 3 mallocs failing / succeeding ended up on the same line as
the options malloc

Cheers

Steve
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-08-19