cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH 0/6] Re: Bug: libcurl truncates passwords longer than 255

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Mon, 19 Aug 2013 16:45:27 +0200

On Monday, August 19, 2013 14:57:01 Steve Holme wrote:
> Hi guys,
>
> On Mon, 19 Aug 2013, Steve Holme wrote:
> > > This way we don't have to try and compare emails with code and don't
> > > have to try and save emails as .patch files where we can get the
> > > line endings wrong or even incorrect line wrappings - From my own
> > > perspective I can then use the built in review features of
> > > TortoiseGIT's ;-)
>
> I'm not sure if my client got things wrong (Outlook) or my provider
> (Hotmail) or whether the code in patch 3 was formatted incorrectly - hence
> my suggestion but perhaps you can help me out...

No idea. I have neither Outlook, nor Hotmail account around to play with.

> The section where user, passwd and options is allocated had the following
> problems towards the end of the patch:
>
> "options =" ended up on the same line as the "passwd = malloc(...)" with the
> malloc on the next line
> The test for the 3 mallocs failing / succeeding ended up on the same line as
> the options malloc

Those patches seem to apply fine on my box. I am attaching them in a tarball
in case it helped.

Kamil

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2013-08-19