cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH v2] Add connection delay to Happy Eyeballs.

From: Björn Stenberg <>
Date: Sun, 3 Nov 2013 15:13:39 +0100

Steve Holme wrote:
> a) Splitting your patches up a little - this one appears to address 2 or 3
> separate issues (the add of the delay, IP address ordering, failed connect
> fix and tidy up) which would help with others reviewing them as well as
> enabling the application of individual parts if necessary

Yes, I feel a bit guilty for posting such a big change in one patch. I asked Daniel about this before posting the patch, and got permission to post it like this.

The reason is simply that the changes were not developed as three different efforts, and splitting them up post facto would require significant backporting effort in order to produce three individual patches that each actually work.

> b) Use our standard format for commit comments as taken from
> contribute.html:

This has no excuse. I will make sure to follow this next time.

Thank you for the feedback.

List admin:
Received on 2013-11-03