cURL / Mailing Lists / curl-library / Single Mail


RE: [PATCH v4] Add connection delay to Happy Eyeballs.

From: Steve Holme <>
Date: Tue, 5 Nov 2013 22:05:57 +0000

On Mon, 4 Nov 2013, Daniel Stenberg wrote:

> > Rebased on commit aa61e1 and adjusted commit message
> > to adhere to template.
> Thanks, this has now been merged and pushed. Let's step up
> the testing now to get this baby rock solid.

A couple of problems in the auto builds:

* The Solaris 10 build is reporting "url.c, line 5581: warning: end-of-loop
code not reached" - while the loop breaks out because of a break statement
it would seem that this loop is no longer required. If either part of the if
statement executes then the break is used to exit the loop, except if there
is a failure in the positive part, in which case the function return a
failure. There doesn't appear to be any need to loop any more as the
continue statement that used to be there has now gone. Am I okay to clean
this up? [1]

* The OpenSuSE 12.1 build is reporting valgrind memory issues in test 583.
Whilst we typically see "in use at exit: 656 bytes in 4 blocks" is there
possibly something else connect wise that is making this test fail? [2]



[1] =
[2] =

List admin:
Received on 2013-11-05