cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH v4] Add connection delay to Happy Eyeballs.

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Mon, 11 Nov 2013 21:14:55 +0000

On Mon, 11 Nov 2013, Steve Holme wrote:

> > Many thanks and pushed - hopefully with the fixes I put in today we
> > should see Guenter's auto builds return to normal ;-)
>
> We seem to have 8 more tests that generate Valgrind errors - which
> all seems to be Proxy CONNECT related :(
>
> http://curl.haxx.se/dev/log.cgi?id=20131111154717-10961#prob19

A bit more info - although no fix at the moment :(

I fired up my proxy server to see if I can reproduce it and it seems to be
that:

* curl_multi_wait() calls multi_getsock() which in turn calls
waitconnect_getsock()
* waitconnect_getsock() then returns 1 due to the TUNNEL_CONNECT test at
multi.c:640 but it doesn't set any of the socket handles
*After the two functions return, curl_multi_wait() then checks bitmap (the
return value) for the READ and WRITE socket bits and sets "s" to an
initialised value from sockbunch :(

I'm certainly no expert in this code but shouldn't waitconnect_getsock() be
returning a socket handle in this instance?

Kind Regards

Steve
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-11-11