Re: [PATCH v4] Add connection delay to Happy Eyeballs.
Date: Mon, 11 Nov 2013 22:24:48 +0100
Steve Holme wrote:
> We seem to have 8 more tests that generate Valgrind errors - which all seems
> to be Proxy CONNECT related :(
Augh, I forgot to reenable valgrind in my pre-submit test! :-(
> Whilst I can fix up un-initialised structures like sockbunch in multi.c:777
> and add VALID_SOCK((sockbunch[i])) to multi.c:803, etc.. I don't believe
> these are the cause of the errors.
> Anyone have any better ideas what the problems could be?
It seems to have something to do with waitconnect_getsock() and the added tempsock initializations. If I comment out line connect.c:761 the valgrind error goes away (but is replaced with a "Close without open").
I'll dig some more and come back with a fix proposal.
- application/pgp-signature attachment: Digital signature