cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: Windows build failures!

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sun, 29 Dec 2013 22:49:47 +0100 (CET)

On Sun, 29 Dec 2013, Steve Holme wrote:

> I have attached my first stab at the fix for anyone that is interested but
> basically it add supports for the non-standard I, I32 and I64 size
> specifiers for compilers (runtime libraries) that support them.

I think this makes perfect sense to do, yes.

> As always any feedback is welcome.

Are you really sure of the memcmp() uses? Shouldn't they rather be strncmp()
to better work with really short format strings as you otherwise risk reading
beyond the buffer boundary?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2013-12-29