cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: More testsuite line-ending improvements to support Windows

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Sun, 2 Feb 2014 10:43:06 +0000

On Sat, 1 Feb 2014, Marc Hoersken wrote:
 
> attached you will find a new set of patches that also includes a
> change to the actual curl tool:
 
Just a quick email from FOSDEM so I will take a look at this email and your patches in further detail later... but have you noticed that on LF based systems that test 1316 is now failing [1], so I just wanted to let you know in case you're not already aware of it ;-)
 
It looks like the test tunnels an FTP connection through a HTTP proxy and because the mode of the <datacheck> is text, LF is compared for the HTTP responses rather than CRLF which looking at the <connect> section these lines have.
 
I'm not sure whether we can split the <datacheck> up into multiple items for example:
 
<datacheck1>
HTTP/1.1 200 Mighty fine indeed
Magic: sure you can FTP me
HTTP/1.1 200 Mighty fine indeed
Magic: sure you can FTP me
</datacheck1>
 
<datacheck2 mode="text">
total 20
drwxr-xr-x 8 98 98 512 Oct 22 13:06 .
drwxr-xr-x 8 98 98 512 Oct 22 13:06 ..
drwxr-xr-x 2 98 98 512 May 2 1996 .NeXT
-r--r--r-- 1 0 1 35 Jul 16 1996 README
lrwxrwxrwx 1 0 1 7 Dec 9 1999 bin -> usr/bin
dr-xr-xr-x 2 0 1 512 Oct 1 1997 dev
drwxrwxrwx 2 98 98 512 May 29 16:04 download.html
dr-xr-xr-x 2 0 1 512 Nov 30 1995 etc
drwxrwxrwx 2 98 1 512 Oct 30 14:33 pub
dr-xr-xr-x 5 0 1 512 Oct 1 1997 usr
</datacheck2>
 
Kind Regards
 
Steve
 
[1] = http://curl.haxx.se/dev/log.cgi?id=20140202021806-5529#prob2
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-02-02