Re: [PATCH] SF bug #1302: HTTP Auth Negotiate sends Kerberos token instead of SPNEGO token
Date: Sun, 13 Jul 2014 21:22:24 +0100
On Sun, 2014-07-13 at 11:31 +0200, Michael Osipov wrote:
> Please have a look:
> Work is based on top of your patches.
That really wants splitting into individual patches to make it readable.
You can't put the OID bytes into the definition as you have; you'll get
complaints about const pointers in some implementations. There was a
reason I had them separate.
And in fact I think you don't need to export them. Just make an enum for
SPNEGO/NTLM/KRB5 and let the caller pass that in, and then you use it to
select the appropriate OID within curl_gssapi.c. And in the SSPI
version, which we want to be called identically, that same enum actually
translates into an appropriate *string* argument to
-- David Woodhouse Open Source Technology Centre David.Woodhouse_at_intel.com Intel Corporation
- application/x-pkcs7-signature attachment: smime.p7s