cURL / Mailing Lists / curl-library / Single Mail

curl-library

HTTP2 warnings

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Tue, 15 Jul 2014 20:05:13 +0100

Hi All,

I don't know whether it is worth fixing these up before the release but I
noticed that the number of warnings in the OpenSuSE autobuilds has increased
from 18 to 30 at some point over the last few weeks.

It seems that they are mainly due to HTTP2 calls in http.c that simply
#define a function to be -1 or a curl error code when the code doesn't
contain a condition.

For example:

/* TODO: add error checking here */
Curl_http2_switched(conn);

Rather than:

If(Curl_http2_switched(conn))
    return some_errorcode;

http://curl.haxx.se/dev/log.cgi?id=20140715145150-31767#prob18

This is the benchmark build that I always keep an eye on which is why I've
mentioned it ;-)

Kind Regards

Steve
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-07-15