cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: spnego_mech_oid & krb5_mech_oid

From: Michael Osipov <1983-01-06_at_gmx.net>
Date: Wed, 23 Jul 2014 17:26:33 +0200

Am 2014-07-23 um 15:40 schrieb Patrick Monnerat:
> Hi friends,
>
> I know a lot of work has been done around GSSAPI these last weeks.
> Unfortunately libcurl does not link anymore on OS/400.

That is actually very good news because some one else, you, took the
time and tested those changes!

Thanks!

> The problem is about the definitions of spnego_mech_oid & krb5_mech_oid:
> in curl_gssapi.h, they are defined as CURL_EXTERN.
> I don't know exactly what are the goals and constraints here, but IMHO
> there should be some update there:
>
> - If we need them accessible to the calling application, they should be
> named curl_... and be declared as CURL_EXTERN in some PUBLIC header
> file.
> - If they are intended for internal use only, they should be named
> Curl_... and be declared extern, not CURL_EXTERN.
>
> In addition, spengo_oid_bytes should probably be named spnego_oid_bytes
> (in curl_gssapi.c): just a typo.

That is a stupid typo on my side.

@Daniel, can you kindly fix that glitch in master?

> I'm 98% sure the OS/400 linking problem can be resolved by either these
> two ways. Please confirm one or the other and I'll fix it. Thanks.

The are used internally only.

My intention was to provide interface like access to those symbols via
the header file, while the implemenation resides in a object file.

If you have a better idea to define them once and use everywhere
internally, please provide a patch!

Thanks,

Michael
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-07-23