cURL / Mailing Lists / curl-library / Single Mail

curl-library

[PATCH] CURLOPT_USERPWD doesn't handle "" (empty string) anymore

From: Toby Peterson <toby_at_apple.com>
Date: Wed, 20 Aug 2014 11:05:18 -0700

Another regression from https://github.com/bagder/curl/commit/fddb7b44a79d78e05043e1c97e069308b6b85f79

That change broke "" and ":" -- Kamil fixed ":" in https://github.com/bagder/curl/commit/abca89aaa0fb208cfaf4ead6692014c4e553388a

The previous code did this:

  separator = strchr(option, ':');
  if(separator != NULL) {
    ...
  } else {
    result = setstropt(user_storage, option);
  }

Since the fact that CURLOPT_USERPWD worked with an empty string was undocumented, feel free to reject the patch. Looks like the change that started allowing "" was https://github.com/bagder/curl/commit/08cf6780ba8ea242cb451f07e14bb572079e22cf, so it worked for ~4.5 years.

- Toby

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2014-08-20