cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] smtps with openssl

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Sat, 27 Sep 2014 21:14:49 +0100

On Fri, 26 Sep 2014, Nagel, Bill wrote:

> > Additionally, is this behaviour of OpenSSL documented anywhere as:
>
> There is a thread about it here:

Cheers for that - most useful from my point of view.

I guess the next question is: Should we fix the problem in smtp.c (as you suggested) or should we use the suggested SSL_MODE flags that are discussed in that thread in our OpenSSL layer?

If possible I would like some input from some of our other contributors on the latter as this is a little out of my curl knowledge unfortunately :(

Also - in order to compile your patch under Windows (VC10) I needed to change the definition of "const char *eob;" to "char *eob;" as I got the following compilation warnings:

warning C4090: 'function' : different 'const' qualifiers on "free(eob);"
warning C4090: '=' : different 'const' qualifiers on " pp->sendthis = eob;"

Do you see those warnings and do you think my modification is the correct thing to do?

I am happy to push the patch now I understand the problem but like I say I would like to open up the discussion with our OpenSSL experts first as I feel we are taking a sledgehammer approach by fixing it in smtp.c when only one SSL backend shows this behaviour.

Kind Regards

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-09-27